[libcxx-commits] [PATCH] D144395: [runtimes] Move common functions from Handle{Libcxx, Libcxxabi, Libunwind}Flags.cmake to runtimes/cmake/Modules/HandleFlags.cmake

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 20 10:39:47 PST 2023


arichardson added inline comments.


================
Comment at: runtimes/cmake/Modules/HandleFlags.cmake:44
+  foreach(value ${ARGN})
+    list(APPEND ${DEST} ${value})
+    list(APPEND ${DEST} ${value})
----------------
Is there a reason that this appends twice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144395/new/

https://reviews.llvm.org/D144395



More information about the libcxx-commits mailing list