[libcxx-commits] [PATCH] D132312: [libc++][spaceship] Implement `operator<=>` for `list`

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang added inline comments.


================
Comment at: libcxx/test/support/test_container_comparisons.h:78
+
+  return true;
+}
----------------
Mordante wrote:
> I think these tests can be extended a bit, it feels like they now use a small number of types. I also miss tests for `<=` to be true/false for certain values.
I am not sure I understand what you are asking for here

> use a small number of types

which additional types would you like to see? Afaict, the test case covers enough types such that we have all comparison categories covered?

> I also miss tests for <= to be true/false for certain values.

`testOrder` calls `testComparisonsComplete` which also covers `<=`. Or am I misunderstanding your request for additional test coverage


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132312/new/

https://reviews.llvm.org/D132312