[libcxx-commits] [PATCH] D136356: [libc++] implement move_iterator<T*> should be a random access iterator

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 18 05:30:09 PST 2023


Mordante requested changes to this revision.
Mordante added a comment.
This revision now requires changes to proceed.

Thanks for your contribution!Please rebase the patch and make sure it can be applied, then the CI can test your patch.



================
Comment at: libcxx/include/__iterator/move_iterator.h:63
     private:
-   
-   static constexpr auto _Get_Iterator_Tag() {
-     if constexpr (__is_cpp17_random_access_iterator<_Iter>::value) {
+    #if _LIBCPP_STD_VER > 17
+   static consteval auto _get_iterator_concept() {
----------------
This is a style change we recently did.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136356/new/

https://reviews.llvm.org/D136356



More information about the libcxx-commits mailing list