[libcxx-commits] [PATCH] D143816: [libc++] Fixes a flaky test.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D143816#4132993 <https://reviews.llvm.org/D143816#4132993>, @ldionne wrote:

> I think I like those changes, however I am wondering -- does the test still fail as reliably with those changes? Did you run it on the backdeployment host with those changes and you could see it fail pretty much as often as before? If so, this LGTM. If this makes the test not reproduce (or reproduce much less frequently), then we're reducing its effectiveness and I'd argue we shouldn't.

Well it seems the CI hates me ;-) The original test, the sleep before mutex, and even removing the sleep are running stable on the Mac. I will try again another time.

> LGTM assuming this does not power-down the test.

It shouldn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143816/new/

https://reviews.llvm.org/D143816