[libcxx-commits] [PATCH] D143383: [libc++][test] Removes rapid-cxx-test.h.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added a comment.

Thanks for the review.



================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/file_size.pass.cpp:108
     ExceptionChecker Checker(p, TC.expected_err, "directory_entry::file_size");
-    TEST_CHECK_THROW_RESULT(filesystem_error, Checker, ent.file_size());
+    TEST_VALIDATE_EXCEPTION(filesystem_error, Checker, ent.file_size());
   }
----------------
ldionne wrote:
> You're missing an include of `assert_macros.h` here.
Agreed, the tests still worked due to `filesystem_test_helper.h` including this file.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp:171
                              "directory_entry::hard_link_count");
-    TEST_CHECK_THROW_RESULT(filesystem_error, Checker, ent.hard_link_count());
+    TEST_VALIDATE_EXCEPTION(filesystem_error, Checker, ent.hard_link_count());
   }
----------------
ldionne wrote:
> Same here, and probably elsewhere.
I had that already done locally.

Due to the changes in the parent patch I've given the patch another CI run to make sure everything still works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143383/new/

https://reviews.llvm.org/D143383