[libcxx-commits] [PATCH] D143329: [libc++] Move constexpr <cstring> functions into their own headers and remove unused <cstring> includes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__string/constexpr_c_functions.h:10
+#ifndef _LIBCPP___STRING_CONSTEXPR_C_FUNCTIONS_H
+#define _LIBCPP___STRING_CONSTEXPR_C_FUNCTIONS_H
+
----------------
philnik wrote:
> Mordante wrote:
> > I would name the file `constexpr_c_functions.h`, these are all private functions and not C functions, so the current name is slightly misleading.
> I'm a bit confused. I guess you would like a different name, but your suggestion is identical to the current name. Did you forget to replace the name?
> I'm a bit confused. I guess you would like a different name, but your suggestion is identical to the current name. Did you forget to replace the name?

Copy-paste error ;-)

I would name the file `constexpr_functions.h`, these are all private functions and not C functions, so the current name is slightly misleading.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143329/new/

https://reviews.llvm.org/D143329