[libcxx-commits] [PATCH] D143816: [libc++] Fixes a flaky test.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D143816#4132993 <https://reviews.llvm.org/D143816#4132993>, @ldionne wrote:

> I think I like those changes, however I am wondering -- does the test still fail as reliably with those changes? Did you run it on the backdeployment host with those changes and you could see it fail pretty much as often as before? If so, this LGTM. If this makes the test not reproduce (or reproduce much less frequently), then we're reducing its effectiveness and I'd argue we shouldn't.
>
> LGTM assuming this does not power-down the test.

I didn't run this version on back-deployment, I can do that tomorrow. During testing I've tested with a version where I removed the sleep entirely and I got the feeling it made the test less stable on Mac. At that time I didn't investigate it further and I wasn't aware of the real issue on the Mac.



================
Comment at: libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp:78-79
+        //
+        // Keep track of how often that happens, when too often the test needs
+        // to be improved.
+        if(threads_active == 0)
----------------
ldionne wrote:
> 
Thanks, `when` is indeed not intended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143816/new/

https://reviews.llvm.org/D143816