[libcxx-commits] [PATCH] D142972: [libc++] Granularize <atomic>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM!
Since the patch already most likely breaks possible patches, I would suggest to do a followup patch to change some code to our current preferred style. WDYT?



================
Comment at: libcxx/include/__atomic/aliases.h:28
+
+typedef atomic<bool>               atomic_bool;
+typedef atomic<char>               atomic_char;
----------------
Suggestion, change this to `using` in a NFC follow up patch.


================
Comment at: libcxx/include/__atomic/atomic.h:37
+#if _LIBCPP_STD_VER > 17
+    _LIBCPP_INLINE_VISIBILITY
+    atomic() = default;
----------------
Followup suggestion s/_LIBCPP_INLINE_VISIBILITY/_LIBCPP_HIDE_FROM_ABI/


================
Comment at: libcxx/include/__atomic/atomic_sync.h:87
+bool __cxx_nonatomic_compare_equal(_Tp const& __lhs, _Tp const& __rhs) {
+    return _VSTD::memcmp(&__lhs, &__rhs, sizeof(_Tp)) == 0;
+}
----------------
Followup suggestion s/_VSTD/std/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142972/new/

https://reviews.llvm.org/D142972