[libcxx-commits] [PATCH] D141882: [libc++] Remove #pragma GCC system_header

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

> it's just a matter of replacing `-I` with `-isystem` to get the correct behaviour

`-I` is ahead of `-isystem` in the header search path list, so just swapping the flags might not work as expected, since the libc++ headers need to be ordered in a particular way with respect to the resource directory and C library headers (and potentially other platform-specific headers, such as libandroid_support for Android). I'm fine with this change (we'll need to clean up some tech debt, but this is good motivation to get that done); I just wanted to point out that it's not always just as simple as "use `-isystem` instead of `-I`".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141882/new/

https://reviews.llvm.org/D141882