[libcxx-commits] [PATCH] D143816: [libc++] Fixes a flaky test.

[Hui via Phabricator via libcxx-commits]

huixie90 added a comment.

hmm. I am not sure if I understand why we need to change the test. According to the description, it is not the test that is flaky. Instead, it is the system under test (the dylib which contains the bug) that is flaky.
So the test does exact what it should do: detect the bug. The fact that it fails very frequently probably means that it does a good job.

the added assertion might actually makes the test flaky since that totally depends on the scheduler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143816/new/

https://reviews.llvm.org/D143816