[libcxx-commits] [PATCH] D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

LGTM modulo one request.

For future reviews, when you address a review comment, can you mark it as done? That makes reviewing patches a second time a lot easier.



================
Comment at: libcxx/test/libcxx/vendor/ibm/bad_function_call.pass.cpp:21
+
+void test_throw() {
+#ifndef TEST_HAS_NO_EXCEPTIONS
----------------
I think it would be good to also have the non-throwing call to f you originally had.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675