[libcxx-commits] [PATCH] D143688: [libc++] Guard the fix to CityHash behind ABI v2

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 15 07:51:05 PST 2023


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/utility/__murmur2_or_cityhash.pass.cpp:15
+// be an ABI break.
+// REQUIRES: libcpp-abi-version=2
+
----------------
Mordante wrote:
> Is there also a test that ABI=V1 keeps returning the same "wrong" value?
Good point, see D144107.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143688/new/

https://reviews.llvm.org/D143688



More information about the libcxx-commits mailing list