[libcxx-commits] [PATCH] D142864: [libc++] `<algorithm>`: `ranges::minmax` should dereference iterators only once

[Igor Zhukov via Phabricator via libcxx-commits]

fsb4000 updated this revision to Diff 497247.
fsb4000 added a comment.

Strange, the previous version works on Windows.

  C:\Dev\STL\llvm-project\build>python bin\llvm-lit.py ..\libcxx\test\std\algorithms\alg.sorting\alg.min.max\ranges.max.pass.cpp -v
  llvm-lit.py: C:\Dev\STL\llvm-project\libcxx\utils\libcxx\test\newconfig.py:19: note: (llvm-libc++-shared-clangcl.cfg.in) Using %{cxx} substitution: ''C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/Llvm/bin/clang-cl.exe''
  llvm-lit.py: C:\Dev\STL\llvm-project\libcxx\utils\libcxx\test\newconfig.py:19: note: (llvm-libc++-shared-clangcl.cfg.in) Using %{flags} substitution: '--driver-mode=g++ --target=i686-pc-windows-msvc'
  llvm-lit.py: C:\Dev\STL\llvm-project\libcxx\utils\libcxx\test\newconfig.py:19: note: (llvm-libc++-shared-clangcl.cfg.in) Using %{compile_flags} substitution: '-nostdinc++ -I %{include} -I %{target-include} -I %{libcxx}/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -DTEST_WINDOWS_DLL'
  llvm-lit.py: C:\Dev\STL\llvm-project\libcxx\utils\libcxx\test\newconfig.py:19: note: (llvm-libc++-shared-clangcl.cfg.in) Using %{link_flags} substitution: '-llibc++experimental -nostdlib -L %{lib} -lc++ -lmsvcrt -lmsvcprt -loldnames'
  llvm-lit.py: C:\Dev\STL\llvm-project\libcxx\utils\libcxx\test\newconfig.py:19: note: (llvm-libc++-shared-clangcl.cfg.in) Using %{exec} substitution: '%{executor} --execdir %T --env PATH=%{lib} -- '
  llvm-lit.py: C:\Dev\STL\llvm-project\libcxx\utils\libcxx\test\newconfig.py:19: note: (llvm-libc++-shared-clangcl.cfg.in) All available features: has-fblocks, locale.ru_RU.UTF-8, c++2b, has-fconstexpr-steps, executor-has-no-bash, -faligned-allocation, windows, locale.zh_CN.UTF-8, diagnose-if-support, locale.fr_CA.ISO8859-1, locale.fr_FR.UTF-8, -fsized-deallocation, clang, buildhost=windows, target=i686-pc-windows-msvc, clang-15.0.1, stdlib=libc++, buildhost=win32, stdlib=llvm-libc++, no-filesystem, windows-dll, msvc, objective-c++, libcpp-abi-version=1, verify-support, locale.en_US.UTF-8, clang-15.0, thread-safety, win32-broken-utf8-wchar-ctype, clang-15, msvc-19, msvc-19.35, fdelayed-template-parsing, c++experimental, long_tests, locale.ja_JP.UTF-8
  -- Testing: 1 tests, 1 workers --
  PASS: llvm-libc++-shared-clangcl.cfg.in :: std/algorithms/alg.sorting/alg.min.max/ranges.max.pass.cpp (1 of 1)
  
  Testing Time: 4.49s
    Passed: 1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142864/new/

https://reviews.llvm.org/D142864

Files:
  libcxx/include/__algorithm/ranges_minmax.h
  libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.minmax.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142864.497247.patch
Type: text/x-patch
Size: 4018 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230214/87eea2d9/attachment.bin>