[libcxx-commits] [PATCH] D143975: [libcxx] Don't trigger -Wuser-defined-literals for headers in build

Tue Feb 14 01:57:00 PST 2023

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

We already add `-Wno-user-defined-literals` in `libcxx/CMakeLists.txt:576`.

In D143975#4124993 <https://reviews.llvm.org/D143975#4124993>, @sunshaoce wrote:

> I don't know why `Group Reviewers libc++` is blocked by `Herald`.

#libc <https://reviews.llvm.org/tag/libc/> is blocking this patch to make sure it's approved by the people working on libc++.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143975/new/

https://reviews.llvm.org/D143975