[libcxx-commits] [PATCH] D143914: [libc++] Clean up pair's constructors and assignment operators

Mon Feb 13 11:37:08 PST 2023

rupprecht added a comment.

In D143914#4123629 <https://reviews.llvm.org/D143914#4123629>, @ldionne wrote:

> In D143914#4123385 <https://reviews.llvm.org/D143914#4123385>, @rupprecht wrote:
>
>> In D143914#4123012 <https://reviews.llvm.org/D143914#4123012>, @ldionne wrote:
>>
>>> Pinging vendors since this is technically a source break. I'll also take this for a run internally to see how much breakage this causes, if any.
>>
>> This one is a bit bigger of a breakage for us. Do you have a target date for landing this patch?
>
> I'd like to do it before the LLVM 17 release, and ideally not too late in the cycle to allow everyone to see this breakage well in advance. How bad is it?

Oh, it's not nearly that bad -- I meant if you were trying to land this in the next day or two :)

My initial sample-based test found 15 breakages. I'll know later how many actual breakages there are.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143914/new/

https://reviews.llvm.org/D143914