[libcxx-commits] [PATCH] D143914: [libc++] Clean up pair's constructors and assignment operators

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I mainly glossed over the code. I like to do a review with a paper or is this the exact wording in the current WP?



================
Comment at: libcxx/include/__utility/pair.h:63
 
+#if _LIBCPP_STD_VER >= 23
+template <class _Tp>
----------------
Does this patch complete a paper/LWG issue?


================
Comment at: libcxx/include/__utility/pair.h:134
 
-    struct _CheckTupleLikeConstructor {
-        template <class _Tuple>
----------------
Would it be hard to keep these removed parts optionally available when using C++ < 23?
If so we could do our normal deprecation method.

For me it's not a blocker if it's too hard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143914/new/

https://reviews.llvm.org/D143914