[libcxx-commits] [PATCH] D143797: [libc++] Mark some variables as inline, per the spec

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: libcxx/include/__config:891
+#  else
+#    define _LIBCPP_INLINE_CONSTEXPR_VAR constexpr // This technically leads to ODR violations, but they are benign.
+#  endif
----------------
I really like to comment!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143797/new/

https://reviews.llvm.org/D143797