[libcxx-commits] [PATCH] D140673: [libc++] Granularize <type_traits> includes in <algorithm>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__algorithm/lower_bound.h:23
 #include <__type_traits/remove_reference.h>
-#include <type_traits>
 
----------------
Interesting to see this header seems not to be needed at all at several places.


================
Comment at: libcxx/test/libcxx/transitive_includes/cxx2b.csv:11
 algorithm new
-algorithm type_traits
 algorithm version
----------------
Please add this to the release notes.


================
Comment at: libcxx/test/std/numerics/bit/bit.endian/endian.pass.cpp:20
 
-#include "test_macros.h"
-
 int main(int, char**) {
     static_assert(std::is_enum<std::endian>::value, "");
----------------
All these changes are unrelated to this patch, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140673/new/

https://reviews.llvm.org/D140673