[libcxx-commits] [PATCH] D143797: [libc++] Mark some variables as inline, per the spec

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this. LGTM, but I would like to bikeshed regarding the name.



================
Comment at: libcxx/include/__config:895
+#  if _LIBCPP_STD_VER >= 17
+#    define _LIBCPP_INLINE_VAR inline
+#  else
----------------
I wonder should we use this instead? And just `constexpr` in the `#else`. For me that makes it easier to understand what the macro does.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143797/new/

https://reviews.llvm.org/D143797