[libcxx-commits] [PATCH] D142806: [libc++] Implement P0226R1 (Mathematical Special Functions)

[Chris Lattner via Phabricator via libcxx-commits]

lattner added a comment.

I'm not familiar with the std::from_chars example, but GoogleBenchmarks is not part of the "shipped" libc++ product, it is an internal implementation detail.

The licensing is definitely the big issue.  If that is resolved we can explore whether it makes sense architecturally to have something like this as part of third party.  I'm personally very concerned about that (for reasons described upthread) but I'm not an active contributor to the subproject. We should widen the discussion to more people to explore the tradeoffs to see if people think it is significant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142806/new/

https://reviews.llvm.org/D142806