[libcxx-commits] [PATCH] D143791: [libc++] Fix bug in allocate_shared_for_overwrite

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added reviewers: huixie90, tcanens.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Instead of destroying the object with allocator::destroy, we must
call its destructor directly. As a fly-by also mark LWG3008 as
fixed since it is handled by our implementation.

This was pointed out by Tim Song in https://reviews.llvm.org/D140913.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143791

Files:
  libcxx/docs/Status/Cxx20Issues.csv
  libcxx/include/__memory/construct_at.h
  libcxx/include/__memory/shared_ptr.h
  libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared_for_overwrite.pass.cpp
  libcxx/test/support/test_allocator.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143791.496621.patch
Type: text/x-patch
Size: 17146 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230210/beacdd46/attachment-0001.bin>