[libcxx-commits] [PATCH] D142842: [libc++] Remove _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION

Fri Feb 10 11:09:43 PST 2023

philnik added a comment.

In D142842#4119097 <https://reviews.llvm.org/D142842#4119097>, @ldionne wrote:

> I don't understand how that's not an ABI break. When `_LIBCPP_ABI_BAD_FUNCTION_CALL_GOOD_WHAT_MESSAGE` is not defined (i.e. in the stable ABI), we don't have a key function. https://reviews.llvm.org/D92397 may be interesting to consult for additional context.

I never said it's not an ABI break. It's just that we already have `bad_function_call::what()` when the unstable ABI is enabled. We don't need two key functions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142842/new/

https://reviews.llvm.org/D142842