[libcxx-commits] [PATCH] D143346: [libc++] fix `shared_ptr`'s incorrect constraints

Fri Feb 10 09:50:45 PST 2023

ldionne added a comment.

In D143346#4117099 <https://reviews.llvm.org/D143346#4117099>, @rupprecht wrote:

> In D143346#4113858 <https://reviews.llvm.org/D143346#4113858>, @ldionne wrote:
>
>> Thanks for fixing this! Only nits.
>>
>> Let's land this and cherry-pick it onto LLVM 16. Please add a release note on the LLVM 16 release branch to explain that this constrains `std::shared_ptr` more than it used to, which could lead to a bit of source break. I don't think this should be too big of a deal, especially since the code this would break is arguably brittle.
>>
>> Pinging vendors for awareness.
>
> Thanks for the ping, @ldionne. As usual, this causes a few breakages for us, but they're all trivial to fix. No concerns from me to land this whenever you're ready.

Thanks a lot for checking!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143346/new/

https://reviews.llvm.org/D143346