[libcxx-commits] [PATCH] D134124: [libc++] Fix wrong implementation of CityHash

Thu Feb 9 13:05:13 PST 2023

ldionne added a comment.

In D134124#4116198 <https://reviews.llvm.org/D134124#4116198>, @oToToT wrote:

> @ldionne Am I right that I should revert this commit now?

No, you're good. I'll handle everything, but thanks a lot for the suggestion.

> I could guard this under ABI v2, too.
> However, I think I could also do a little survey on hash functions and send a patch to discuss which one we should choose.
> WDYT?

I agree, under ABI v2 we can select an arbitrary hash function, so let's select the best one. For the time being that will be the fixed CityHash, but we can use anything else. I suggest you do that on top of my patch that introduces the ABI v2 switch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134124/new/

https://reviews.llvm.org/D134124