[libcxx-commits] [PATCH] D134124: [libc++] Fix wrong implementation of CityHash

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 9 11:58:57 PST 2023


ldionne added a comment.

We ran into an issue while deploying this. This is technically an ABI break as we had noted. I realize I had underestimated the potential for this biting users -- we had users where a `std::unordered_map` was obtained from a different dylib compiled against old libc++ and they were unable to find a key in code built against new libc++ headers.

I think we'll need to guard this under ABI v2, unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134124/new/

https://reviews.llvm.org/D134124



More information about the libcxx-commits mailing list