[libcxx-commits] [PATCH] D143158: [libcxx][test] Cover RISC-V in string.capacity test

Thu Feb 9 10:34:52 PST 2023

philnik added a comment.

In D143158#4115889 <https://reviews.llvm.org/D143158#4115889>, @asb wrote:

> In D143158#4115435 <https://reviews.llvm.org/D143158#4115435>, @philnik wrote:
>
>> We generally require a runner in the libc++ precommit-CI itself. See https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs for more information. Is the post-commit CI documented somewhere? If that's the case we should probably add a sentence about libc++ requiring a pre-commit CI runner. It seems that most people aren't aware of this. D139147 <https://reviews.llvm.org/D139147> might me interesting in case you want to cross-compile the code and run it in an emulator.
>
> Documentation for the main CI is probably mainly here <https://llvm.org/docs/HowToAddABuilder.html> and here <https://llvm.org/docs/DeveloperPolicy.html#working-with-the-ci-system>.

Thanks! I'll look into making a patch to add a note about the libc++ CI.

> Just to check I've understood the infra properly - is the linked ADB patch an example of setting up a new CI job to run "on our existing infrastructure"? Should I expect to be able to submit qemu-based testing on top of the shared libcxx CI infra?

The patch doesn't actually add a configuration to the CI, it just adds everything required to add a configuration. To actually add a configuration `libcxx/utils/ci/buildkite-pipeline.yml` has to be extended. I'm not sure what exactly our requirements are on CI infrastructure, but I think for adding a new platform some compute resources have to be provided. I think the "existing infrastructure" note is mostly about general configurations, like a new C++ version, testing the unstable ABI and similar stuff. I'm not sure though. @ldionne should be able to give a definite answer here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143158/new/

https://reviews.llvm.org/D143158