[libcxx-commits] [PATCH] D143447: [libc++] Implement P1328R1 constexpr std::type_info::operator==

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D143447#4110327 <https://reviews.llvm.org/D143447#4110327>, @ldionne wrote:

> In D143447#4110194 <https://reviews.llvm.org/D143447#4110194>, @aaron.ballman wrote:
>
>> 
>
> It looks like this is the VCRuntime used by the bots being too old and not supporting `constexpr`. I think the right thing to do is to UNSUPPORT the test in that case.
>
> @goncharov @mstorsjo  Would it be possible to update the VCRuntime on the Windows hosts?

I checked on a test setup, and the test was failing with VS 2022 17.1, but started after updating it to VS 2022 17.4. And as it's about constexpr, I guess it shouldn't have any runtime aspect (it should run fine even with an older version of the vcruntime DLLs).

I guess it should be possible to update the CI images. As building the docker images usually is a bit messy (it often ends up requiring fixing some dependency which no longer installs cleanly) I guess @goncharov doesn't want to do it all the time - but we should probably do it once Clang 16.0 is released stable so we can include that. I didn't prod him for updating them with Clang 15.0 (so I would believe that they're still running 14.0) since I didn't have any concrete detail that would benefit from that upgrade at the point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143447/new/

https://reviews.llvm.org/D143447