[libcxx-commits] [PATCH] D142843: [libc++] Addresses LWG3358

Mon Feb 6 07:40:04 PST 2023

philnik added inline comments.

================
Comment at: libcxx/test/std/containers/views/views.span/span.cons/iterator_sentinel.pass.cpp:123
+  std::array a{42};
+  TEST_VALIDATE_EXCEPTION((std::span<int>{throw_operator_minus{a.begin()}, throw_operator_minus{a.end()}}),    //
+                          int,                                                                                 //
----------------
Mordante wrote:
> philnik wrote:
> > Why not just a try/catch like we normally do?
> I added new macros to make this simpler in D142808, this is based on the macros in rapid-cxx-test.h which we have, but they seem quite unknown.
TBH I don't think this is a readability improvement. This just makes it harder to see what's going on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142843/new/

https://reviews.llvm.org/D142843