[libcxx-commits] [PATCH] D143007: [libc++][CI] Uses LLVM 17 in Docker.

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

In D143007#4104804 <https://reviews.llvm.org/D143007#4104804>, @Mordante wrote:

> Thanks for the reviews!
>
> In D143007#4103951 <https://reviews.llvm.org/D143007#4103951>, @jloser wrote:
>
>> In D143007#4103560 <https://reviews.llvm.org/D143007#4103560>, @ldionne wrote:
>>
>>> Is `LLVM_HEAD_VERSION=17` going to work yet?
>>
>> I don't think so based on looking at the code:
>>
>>   declare -A LLVM_VERSION_PATTERNS
>>   LLVM_VERSION_PATTERNS[9]="-9"
>>   LLVM_VERSION_PATTERNS[10]="-10"
>>   LLVM_VERSION_PATTERNS[11]="-11"
>>   LLVM_VERSION_PATTERNS[12]="-12"
>>   LLVM_VERSION_PATTERNS[13]="-13"
>>   LLVM_VERSION_PATTERNS[14]="-14"
>>   LLVM_VERSION_PATTERNS[15]="-15"
>>   LLVM_VERSION_PATTERNS[16]="-16"
>>   LLVM_VERSION_PATTERNS[17]=""
>>   
>>   if [ ! ${LLVM_VERSION_PATTERNS[$LLVM_VERSION]+_} ]; then
>>       echo "This script does not support LLVM version $LLVM_VERSION"
>>       exit 3
>>   fi
>>
>> since `LLVM_VERSION_PATTERNS[17]` is an empty string.
>
> AFAIK That part of the code is to make sure lines like
>
>   deb http://apt.llvm.org/bullseye/ llvm-toolchain-bullseye-15 main
>   deb http://apt.llvm.org/bullseye/ llvm-toolchain-bullseye main
>
> work properly in `sources.list` files in Debian/Ubuntu. Note the the ToT version has no version suffix.
>
> I have tested the Docker file locally with several Clang versions, including 17, before I created this review.
>
> There is one fix queued to be backported to the LLVM-16 after that has landed I'll land this and upload a new Docker image.
> (Without that fix the LLVM-16 branch modular build will fail.)

Ah, I see — you're right after closer inspection of the `llvm.sh` script. This looks fine then — sorry about that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143007/new/

https://reviews.llvm.org/D143007