[libcxx-commits] [PATCH] D143329: [libc++] Move constexpr <cstring> functions into their own headers and remove unused <cstring> includes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

LGTM, modulo the naming of the file.



================
Comment at: libcxx/include/__string/constexpr_c_functions.h:10
+#ifndef _LIBCPP___STRING_CONSTEXPR_C_FUNCTIONS_H
+#define _LIBCPP___STRING_CONSTEXPR_C_FUNCTIONS_H
+
----------------
I would name the file `constexpr_c_functions.h`, these are all private functions and not C functions, so the current name is slightly misleading.


================
Comment at: libcxx/test/libcxx/transitive_includes/cxx20.csv:341
 format cstdlib
-format cstring
 format initializer_list
----------------
Since `<format>` isn't stable yet, I agree this is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143329/new/

https://reviews.llvm.org/D143329