[libcxx-commits] [PATCH] D143164: [libc++][NFC] Rename _LIBCPP_NO_RTTI to _LIBCPP_HAS_NO_RTTI

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 3 14:42:07 PST 2023


philnik added a comment.

In D143164#4103562 <https://reviews.llvm.org/D143164#4103562>, @ldionne wrote:

> This seems fine... however do you plan on doing the same for `_LIBCPP_NO_EXCEPTIONS`? Cause I would perhaps object to that one (on the basis that it probably touches a gazillion lines).

I have D143163 <https://reviews.llvm.org/D143163> for that. Though it mostly touches `istream` and `ostream`, so it's mostly touching code that's just laying around, not a lot that is actively worked on. I can wait for approval from you though and talk about it next week if you think it's too much noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143164/new/

https://reviews.llvm.org/D143164



More information about the libcxx-commits mailing list