[libcxx-commits] [PATCH] D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION

[David Tenty via Phabricator via libcxx-commits]

daltenty accepted this revision.
daltenty added a comment.

Latest format changes LGTM. Small nit about the test comment.



================
Comment at: libcxx/test/libcxx/vendor/ibm/bad_function_call.pass.cpp:12-15
+// When there is a weak hidden symbol in user code and a strong definition
+// in the library, we test that the linker relies on the library version
+// instead of failing.
+#include <functional>
----------------
nit: Tweak this to: 

1. identify the problematic function, since it's not obvious from the code
2. elaborate on the failing case we avoid


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675