[libcxx-commits] [PATCH] D143203: [libc++][format] Fixes test failures.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Most of the additions seem correct, but I don't understand a few of them. I'd like to understand to make sure we're not just blindly adding includes to fix stuff (and to fix what?).



================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.verify.cpp:15-16
 
+#include <iterator> // TODO FMT This should not be required
+#include <string>   // TODO FMT This should probably not be required
+
----------------
Why is this needed? What is this fixing?


================
Comment at: libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp:20
 #include <cassert>
+#include <string>
 #include <vector>
----------------
We're not using `std::string` here right? Why is this needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143203/new/

https://reviews.llvm.org/D143203