[libcxx-commits] [PATCH] D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/vendor/ibm/bad_function_call.pass.cpp:1
+//===-- libc++ export redefined symbols test ------------------------------===//
+//
----------------
Please add the comment at line 10, this is the style we use in libc++


================
Comment at: libcxx/test/libcxx/vendor/ibm/bad_function_call.pass.cpp:16
+
+int main() {
+  std::function<void()> r(foo);
----------------
Some of our platforms require this main signature. These platforms also require an explicit `return 0;` for main.


================
Comment at: libcxx/test/libcxx/vendor/ibm/bad_function_call.pass.cpp:18
+  std::function<void()> r(foo);
+  r();
+}
----------------
This test seems to do nothing, if that is intended please add comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675