[libcxx-commits] [PATCH] D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object

[David Tenty via Phabricator via libcxx-commits]

daltenty accepted this revision.
daltenty added a comment.

LGTM, with a minor tweak



================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:673
+  _LIBCXXABI_TRACE_STATETAB0("skipNonCxxEHAwareFrames() reached the end of stack frames, aborting\n");
+  std::abort();
+}
----------------
Prefer just un-namespaced `abort`, since we don't have the standard library headers in the libcxxabi context.


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:685
+// Note: make sure __xlc_excpetion_handle() is a non-leaf function. Currently
+// it calls skipNonCxxEHAwareFrames(), which in turn calls std::abort().
 _LIBCXXABI_FUNC_VIS uintptr_t __xlc_exception_handle() {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143010/new/

https://reviews.llvm.org/D143010