[libcxx-commits] [PATCH] D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION

[David Tenty via Phabricator via libcxx-commits]

daltenty accepted this revision.
daltenty added a comment.

LGTM, with some minor nits to address before commit. Updated the description to describe the details of the issue.



================
Comment at: libcxx/include/__config:172
 
+#  if defined(_AIX)
+#    define _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION
----------------
nit: for clarity, move this inside the `elif _LIBCPP_ABI_VERSION == 1` block above, since this is already on for ABI version 2.

I recommend a comment too:



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675