[libcxx-commits] [PATCH] D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object

[Xing Xue via Phabricator via libcxx-commits]

xingxue added inline comments.


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:667
+    currentStack = reinterpret_cast<uintptr_t*>(currentStack[0]);
+    // Get the value of the LR from the frame.
+    currentPc = reinterpret_cast<uint32_t*>(currentStack[2]);
----------------
hubert.reinterpretcast wrote:
> Suggestion:
> Get the value of the LR (saved, prior to incrementing the SP, by the prolog of the function just inspected) from the frame.
Changed, thanks for the suggestion!


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:671
+  // This should not happen.
+  _LIBCXXABI_TRACE_STATETAB0("skipNonCxxEHAwareFrames() reached the end of stack frames, terminating\n");
+  std::abort();
----------------
hubert.reinterpretcast wrote:
> 
Good catch, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143010/new/

https://reviews.llvm.org/D143010