[libcxx-commits] [PATCH] D142322: [libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp:1
 //===----------------------------------------------------------------------===//
 //
----------------
It would be nice to run the clang-tidy checks in all the CI jobs that run inside our Docker container.


================
Comment at: libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp:22-26
     check_factories.registerCheck<libcpp::abi_tag_on_virtual>("libcpp-avoid-abi-tag-on-virtual");
     check_factories.registerCheck<libcpp::hide_from_abi>("libcpp-hide-from-abi");
     check_factories.registerCheck<libcpp::robust_against_adl_check>("libcpp-robust-against-adl");
     check_factories.registerCheck<libcpp::qualify_declval>("libcpp-qualify-declval");
+    check_factories.registerCheck<libcpp::uglify_attributes>("libcpp-uglify-attributes");
----------------
Consider sorting alphabetically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142322/new/

https://reviews.llvm.org/D142322