[libcxx-commits] [PATCH] D142180: [libc++] Enforce formatting for already formatted and new files and ignore the formatting of tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 1 09:02:10 PST 2023


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Let's do this. We've been living in this transitional state for long enough.



================
Comment at: libcxx/utils/ci/run-buildbot:185
 ;;
 check-generated-output)
     # `! foo` doesn't work properly with `set -e`, use `! foo || false` instead.
----------------
It would be nice if `check-generated-output` failed when we format a file but we forget to update `ignore_format.txt`. This can be done by reusing the `libcxx/utils/generate_ignore_format.sh` script you already have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142180/new/

https://reviews.llvm.org/D142180



More information about the libcxx-commits mailing list