[libcxx-commits] [PATCH] D143071: [libc++] Add abi_tag on __exception_guard to avoid ODR violations

[Alexander Kornienko via Phabricator via libcxx-commits]

alexfh added inline comments.


================
Comment at: libcxx/include/__utility/exception_guard.h:61
 
 #ifndef _LIBCPP_NO_EXCEPTIONS
 template <class _Rollback>
----------------
Should this be moved inside the definition of the class to make it clear which code is shared between the _LIBCPP_NO_EXCEPTIONS and !_LIBCPP_NO_EXCEPTIONS modes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143071/new/

https://reviews.llvm.org/D143071