[libcxx-commits] [PATCH] D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object

[Chris Bowler via Phabricator via libcxx-commits]

cebowleratibm added inline comments.


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:665
+
+    // Move up one stack frame.
+    currentStack = reinterpret_cast<uintptr_t*>(currentStack[0]);
----------------
cebowleratibm wrote:
> I'm not convinced this can be removed.  The implementation still moves up at least as many frames as it did before.
Suggest: add a print statement each time we skip a frame.  In general this should only happen when the XL compiler injects a wrapper and it's probably of interest to the trace that we're bypassing wrapper frames enroute to the frame that contains the landing pad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143010/new/

https://reviews.llvm.org/D143010