[libcxx-commits] [PATCH] D133661: [libc++] Improve binary size when using __transaction

Wed Feb 1 07:06:27 PST 2023

philnik added a comment.

In D133661#4096544 <https://reviews.llvm.org/D133661#4096544>, @rupprecht wrote:

> In D133661#4096429 <https://reviews.llvm.org/D133661#4096429>, @alexfh wrote:
>
>> In D133661#4096263 <https://reviews.llvm.org/D133661#4096263>, @alexfh wrote:
>>
>>> @philnik could you commit one of the proposed abi_tag fixes?
>>
>> Actually, I went ahead and committed it as 561105fb9d3a16f7fb8c718cc5da71b11f17a144 <https://reviews.llvm.org/rG561105fb9d3a16f7fb8c718cc5da71b11f17a144> to unblock us. Hopefully, that's small and obvious enough to not violate the code review policies.
>
> libc++ has a pretty good precommit test infra that gets triggered when a review is created, so in the future it would be better to create a review and wait for CI before landing w/o review.
>
> Although `gnu::abi_tag` was suggested, I took that to mean `__attribute__((__abi_tag__(...)))` when I tested the suggestion locally, as elsewhere libc++ uses ABI tags like so:
>
>   #    define _LIBCPP_HIDE_FROM_ABI                                                                                      \
>         _LIBCPP_HIDDEN _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION                                                       \
>             __attribute__((__abi_tag__(_LIBCPP_TOSTRING(_LIBCPP_VERSIONED_IDENTIFIER))))

I reverted, since that breaks C++03. I'll upload a proper fix probably by the end of the day.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133661/new/

https://reviews.llvm.org/D133661