[libcxx-commits] [libcxx] [libc++] Deprecates and removes shared_ptr::unqiue. (PR #76576)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Dec 30 08:23:28 PST 2023


mordante wrote:

> @ldionne
> 
> As always, please provide an opt-out for this for a release, so that it's possible to roll this in, and then do the cleanup async after the update.
> 
> (The basic_string removal for example took us months due to depa being slow in accepting PRs. That's done now, but without advance notice before the removal, we we wouldn't have been able to update libc++ for months, and in the meantime a bunch of similar things would have landed.)

There is an opt-out `_LIBCPP_ENABLE_CXX20_REMOVED_SHARED_PTR_UNIQUE`. If this does not work for chromium, then it would be nice if you or somebody from chromium can join the monthly libc++ meeting see how we can do these changes in an easier way for chromium. (I can make other changes before that time, but then please explain why the current opt-out does not work.)

https://github.com/llvm/llvm-project/pull/76576


More information about the libcxx-commits mailing list