[libcxx-commits] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

> > @mordante I have three issues:
> > ```
> > 1. I disabled the deprecation warning or `visit_format_arg()` in the `visit.pass.cpp` file with `TEST_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations")`. But many more tests are failing, even in tests (IMO) which are not related directly. What do I need to do?
> > ```
> 
> Can you post links to the failed tests? Preferably on Discord, that makes the discussion easier.
> 
> > ```
> > 2. The declaration of `visit` uses `deducing this`, which is available in Clang 18 only. As far I can tell the complication fails due to `clang-tidy 17` being used in the CI.
> > ```
> 
> I recently ran into the same issue, we probably should suggest moving the the latest clang-tidy in the CI. I expect you need to disable some tests for older clang versions too and maybe in the code guard the code with the appropriate compiler FTM.
> 
> > ```
> > 3. The test of the `handle` for `visit<R>()` is failing, so I have skipped it for now.
> > ```
> 
> Let's also discuss this on Discord.
> 
> I mainly glossed over the patch I haven't done a detailed review. I want to wait until the patch is no longer a draft.

I believe I resolved issues 1 and 3 and only the clang-tidy 17 one remained to be resolved.

https://github.com/llvm/llvm-project/pull/76449