[libcxx-commits] [libcxx] [libc++][format] P2637R3: Member `visit` (PR #76449)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

@mordante I have three issues:
1. I disabled the deprecation warning or `visit_format_arg()` in the `visit.pass.cpp` file with `TEST_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations")`. But many more tests are failing, even in tests (IMO) which are not related directly. What do I need to do?
2. The declaration of `visit` uses `deducing this`, which is available in Clang 18 only. As far I can tell the complication fails due to `clang-tidy 17` being used in the CI.
3.  The test of the `handle` for `visit<R>()` is failing, so I have skipped it for now.

https://github.com/llvm/llvm-project/pull/76449