[libcxx-commits] [libcxx] [libc++][test] enable_borrowed_range compile -> verify for ranges::as_rvalue_view (PR #75066)

Will Hawkins via libcxx-commits libcxx-commits at lists.llvm.org
Sun Dec 24 19:47:31 PST 2023


hawkinsw wrote:

> I also don't understand this change. It doesn't add any expected diagnostics and the test seems to have worked just fine without this change.

Sorry for the confusion -- per @var-const in another PR, I was under the impression that we wanted tests that contain only `static_assert`s to be *verify* tests. If I misunderstood him, please forgive me -- it would be entirely my fault and no one should blame him. Again, I am just trying to be helpful. If this is something that people do not want, please feel free to say no. I can go on to other things and stop bothering you all!

That said, I think that I agree with @mordante that it might make sense to make a renaming change such as this to all tests at the same time? 

https://github.com/llvm/llvm-project/pull/75066


More information about the libcxx-commits mailing list