[libcxx-commits] [libcxx] [libc++][hardening] Categorize more assertions. (PR #75918)

[Mark de Wever via libcxx-commits]

================
@@ -4587,28 +4587,36 @@ public:
 
   // element access:
   _LIBCPP_HIDE_FROM_ABI difference_type length(size_type __sub = 0) const {
-    _LIBCPP_ASSERT_UNCATEGORIZED(ready(), "match_results::length() called when not ready");
+    // If the match results are not ready, this will return `0`.
+    _LIBCPP_ASSERT_PEDANTIC(ready(), "match_results::length() called when not ready");
----------------
mordante wrote:

Since this likely gives the wrong result and is explicitly done by the developer I would make this a stronger assert.

https://github.com/llvm/llvm-project/pull/75918