[libcxx-commits] [libcxx] [ASan][libc++] String annotations optimizations fix with lambda (PR #76200)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 22 11:18:03 PST 2023


https://github.com/ldionne approved this pull request.

I'm fine with this (with a nitpick about the comment, which I think doesn't add much). This is kind of just a cleaner way to write the same thing as before, so even better if it fixes an optimization problem.

If this were making the code harder to read or more complicated, I'd ask for at least a regression test but in this case we can pretend that it's just a slight "refactoring", even though it is motivated by fixing a regression. It would be good to have some kind of regression test is that's feasible, though.

https://github.com/llvm/llvm-project/pull/76200


More information about the libcxx-commits mailing list