[libcxx-commits] [libcxx] [libc++][ranges][abi-break] Fix `movable_box` overwriting memory of data that lives in the tail padding (PR #71314)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 22 09:24:38 PST 2023


================
@@ -8,49 +8,73 @@
 
----------------
ldionne wrote:

I might suggest keeping the old test around, but renaming it to something like `empty_object.pass.cpp`, since it seems to have been written specifically to test something about empty objects. I don't remember why I wrote it that way anymore, and https://reviews.llvm.org/D102135 is not responsive right now but I suspect there might be a rationale.

I would also rename copyable-box to movable-box as a drive-by in that test file, since it was forgotten when we renamed the type.

https://github.com/llvm/llvm-project/pull/71314


More information about the libcxx-commits mailing list