[libcxx-commits] [libcxx] [libcxx][NFC] Rename iterator/sentinel type template parameter names (PR #76201)
via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Dec 21 19:47:03 PST 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 847a6f8f0a6b9b98f2a219c7af59306e9b03b796 1a4a4235b0639e77a88010df1c4a97e0ffca2571 -- libcxx/test/std/ranges/range.adaptors/range.chunk.by/range.chunk.by.iter/compare.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk.by/range.chunk.by.iter/decrement.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/iterator/arrow.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/iterator/base.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/iterator/ctor.parent_iter.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/iterator/decrement.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/iterator/deref.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/base.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/compare.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.default.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.parent.pass.cpp libcxx/test/std/ranges/range.adaptors/range.filter/types.h
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/arrow.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/arrow.pass.cpp
index 8a12b1694c..bee53bf932 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/arrow.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/arrow.pass.cpp
@@ -76,7 +76,7 @@ static_assert(std::ranges::input_range<WithNonCopyableIterator>);
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
std::array<XYPoint, 5> array{{{0, 0}, {1, 1}, {2, 2}, {3, 3}, {4, 4}}};
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterIterator = std::ranges::iterator_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/base.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/base.pass.cpp
index 813cd892c6..ccffead505 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/base.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/base.pass.cpp
@@ -23,7 +23,7 @@
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterIterator = std::ranges::iterator_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/ctor.parent_iter.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/ctor.parent_iter.pass.cpp
index 761ef2d8ee..b3fd99c848 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/ctor.parent_iter.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/ctor.parent_iter.pass.cpp
@@ -20,7 +20,7 @@
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterIterator = std::ranges::iterator_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/decrement.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/decrement.pass.cpp
index af3140a153..9e8c47fd5e 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/decrement.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/decrement.pass.cpp
@@ -40,7 +40,7 @@ using FilterIteratorFor = std::ranges::iterator_t<
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, EqualTo>;
using FilterIterator = std::ranges::iterator_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/deref.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/deref.pass.cpp
index f4f4982bb9..23843f4f46 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/deref.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/iterator/deref.pass.cpp
@@ -23,7 +23,7 @@
template <class Iter, class ValueType = int, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterIterator = std::ranges::iterator_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/base.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/base.pass.cpp
index bd0ba63a89..a6755b3e20 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/base.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/base.pass.cpp
@@ -21,7 +21,7 @@
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterSentinel = std::ranges::sentinel_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.default.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.default.pass.cpp
index 039236a785..826d37138a 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.default.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.default.pass.cpp
@@ -18,7 +18,7 @@
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterSentinel = std::ranges::sentinel_t<FilterView>;
FilterSentinel sent1{};
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.parent.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.parent.pass.cpp
index 9896bf80c3..17641d8e71 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.parent.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/sentinel/ctor.parent.pass.cpp
@@ -21,7 +21,7 @@
template <class Iter, class Sent = sentinel_wrapper<Iter>>
constexpr void test() {
- using View = minimal_view<Iter, Sent>;
+ using View = minimal_view<Iter, Sent>;
using FilterView = std::ranges::filter_view<View, AlwaysTrue>;
using FilterSentinel = std::ranges::sentinel_t<FilterView>;
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/types.h b/libcxx/test/std/ranges/range.adaptors/range.filter/types.h
index 781741e3bc..eed21faaf2 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/types.h
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/types.h
@@ -33,10 +33,7 @@ struct AlwaysTrue {
template <class Iter, class Sent>
struct minimal_view : std::ranges::view_base {
- constexpr explicit minimal_view(Iter it, Sent sent)
- : it_(base(std::move(it)))
- , sent_(base(std::move(sent)))
- { }
+ constexpr explicit minimal_view(Iter it, Sent sent) : it_(base(std::move(it))), sent_(base(std::move(sent))) {}
minimal_view(minimal_view&&) = default;
minimal_view& operator=(minimal_view&&) = default;
``````````
</details>
https://github.com/llvm/llvm-project/pull/76201
More information about the libcxx-commits
mailing list